immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-09-30 21:28:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(mobile): don't stack an upload with itself (#31851)

Browse Source
This commit is contained in:
Santo Shakil
2026-09-28 22:15:04 +06:00
committed by GitHub
parent ae49913223
commit 638b6ac553
2 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mobile/lib/domain/services/asset.service.dart
+1 -1
View File
@@ -204,7 +204,7 @@ class AssetService {
try {
// previous_checksum still points at the version the server had before this upload
final previousId = await _localRepository.getPreviousRemoteId(localId);
if (previousId != null) {
if (previousId != null && previousId != remoteId) {
await _apiRepository.stack([remoteId, previousId]);
}
} finally {
mobile/test/unit/services/asset_service_test.dart
+9
View File
@@ -150,6 +150,15 @@ void main() {
verify(() => mocks.localAsset.repo.updatePreviousChecksum('local', 'sha')).called(1);
});
test('does not stack an upload onto itself', () async {
when(() => mocks.localAsset.repo.getPreviousRemoteId('local')).thenAnswer((_) async => 'remote');
await sut.stackEditedUpload('local', 'remote', 'sha');
verifyNever(() => apiRepository.stack(any()));
verify(() => mocks.localAsset.repo.updatePreviousChecksum('local', 'sha')).called(1);
});
test('records the uploaded checksum even when the stack call fails', () async {
when(() => mocks.localAsset.repo.getPreviousRemoteId('local')).thenAnswer((_) async => 'previous');
when(() => apiRepository.stack(any())).thenThrow(Exception('offline'));