chore(deps): update dependency eslint-plugin-unicorn to v75 (#31721)

Co-authored-by: Daniel Dietzler <mail@ddietzler.dev>

packages/cli/package.json

@@ -33,7 +33,7 @@
     "eslint": "^10.0.0",
     "eslint-config-prettier": "^10.1.8",
     "eslint-plugin-prettier": "^5.1.3",
-    "eslint-plugin-unicorn": "^73.0.0",
+    "eslint-plugin-unicorn": "^75.0.0",
     "globals": "^17.0.0",
     "mock-fs": "^5.2.0",
     "prettier": "^3.7.4",

packages/cli/src/commands/asset.ts

@@ -199,10 +199,7 @@ export const checkForDuplicates = async (files: string[], { concurrency, skipHas
         format: '{message} | {bar} | {percentage}% | ETA: {eta_formatted} | {value}/{total}',
         formatValue: (v: number, options, type) => {
           // Don't format percentage
-          if (type === 'percentage') {
-            return v.toString();
-          }
-          return byteSize(v).toString();
+          return type === 'percentage' ? v.toString() : byteSize(v).toString();
         },
         etaBuffer: 100, // Increase samples for ETA calculation
       },
@@ -563,12 +560,15 @@ const updateAlbums = async (assets: Asset[], options: UploadOptionsDto) => {
       continue;
     }
     const albumId = existingAlbums.get(albumName);
-    if (albumId) {
-      if (!albumToAssets.has(albumId)) {
-        albumToAssets.set(albumId, []);
-      }
-      albumToAssets.get(albumId)?.push(asset.id);
+
+    if (!albumId) {
+      continue;
     }
+
+    if (!albumToAssets.has(albumId)) {
+      albumToAssets.set(albumId, []);
+    }
+    albumToAssets.get(albumId)?.push(asset.id);
   }
 
   const albumUpdateProgress = new SingleBar(

packages/cli/src/utils.ts

@@ -63,14 +63,16 @@ export const requirePermissions = async (permissions: Permission[]) => {
     }
   }
 
-  if (missing.length > 0) {
-    const combined = missing.map((permission) => `"${permission}"`).join(', ');
-    console.log(
-      `Missing required permission${s(missing.length)}: ${combined}.
-Please make sure your API key has the correct permissions.`,
-    );
-    process.exit(1);
+  if (missing.length === 0) {
+    return;
   }
+
+  const combined = missing.map((permission) => `"${permission}"`).join(', ');
+  console.log(
+    `Missing required permission${s(missing.length)}: ${combined}.
+Please make sure your API key has the correct permissions.`,
+  );
+  process.exit(1);
 };
 
 export const connect = async (url: string, key: string) => {
@@ -120,10 +122,7 @@ export const readAuthFile = async (dir: string) => {
     // TODO add class-transform/validation
     const auth = yaml.parse(data.toString()) as AuthDto | OldAuthDto;
     const { instanceUrl, apiKey } = auth as OldAuthDto;
-    if (instanceUrl && apiKey) {
-      return { url: instanceUrl, key: apiKey };
-    }
-    return auth as AuthDto;
+    return instanceUrl && apiKey ? { url: instanceUrl, key: apiKey } : (auth as AuthDto);
   } catch (error: Error | any) {
     if (error.code === 'ENOENT' || error.code === 'ENOTDIR') {
       console.log('No auth file exists. Please login first.');