From 5dd94521f39b2bc88ed644d672eab868be2dfc7b Mon Sep 17 00:00:00 2001
From: Jason Rasmussen <jason@rasm.me>
Date: Wed, 9 Sep 2026 16:34:32 -0400
Subject: [PATCH] fix: github link (#800)

chore: github link
---
 .../src/lib/components/GithubReference.svelte | 26 --------------
 .../github-link/BasicExample.svelte           |  5 +--
 .../components/GithubLink/GithubLink.svelte   | 34 ++-----------------
 packages/ui/src/lib/types.ts                  |  8 +----
 4 files changed, 4 insertions(+), 69 deletions(-)
 delete mode 100644 apps/root.immich.app/src/lib/components/GithubReference.svelte

diff --git a/apps/root.immich.app/src/lib/components/GithubReference.svelte b/apps/root.immich.app/src/lib/components/GithubReference.svelte
deleted file mode 100644
index 3f032b76..00000000
--- a/apps/root.immich.app/src/lib/components/GithubReference.svelte
+++ /dev/null
@@ -1,26 +0,0 @@
-<script lang="ts">
-  import { Link } from '@immich/ui';
-
-  type Props = {
-    org?: string;
-    repo?: string;
-    number: number;
-  };
-
-  let { org = 'immich-app', repo = 'immich', number }: Props = $props();
-
-  const getLink = (org: string, repo: string, number: number) => {
-    const href = `https://github.com/${org}/${repo}/issues/${number}`;
-    let text = repo === 'immich' ? `#${number}` : `${repo}#${number}`;
-
-    if (org !== 'immich-app') {
-      text = `${org}/${repo}#${number}`;
-    }
-
-    return { href, text };
-  };
-
-  let { href, text } = $derived(getLink(org, repo, number));
-</script>
-
-<Link {href}>{text}</Link>
diff --git a/apps/ui.immich.app/src/routes/(docs)/components/github-link/BasicExample.svelte b/apps/ui.immich.app/src/routes/(docs)/components/github-link/BasicExample.svelte
index 6b2e6c9f..7e815a0c 100644
--- a/apps/ui.immich.app/src/routes/(docs)/components/github-link/BasicExample.svelte
+++ b/apps/ui.immich.app/src/routes/(docs)/components/github-link/BasicExample.svelte
@@ -12,14 +12,11 @@
 <Heading size="small" class="mt-4">Another org</Heading>
 <GithubLink org="kysely-org" repo="kysely" number={64} />
 
-<Heading size="small" class="mt-4">No icon</Heading>
-<GithubLink number={64} icon={false} />
-
 <Stack gap={4} class="mt-4">
   <ComponentSizes>
     {#snippet child({ size })}
       <Text {size}>
-        For example, issue <GithubLink {size} number={1} /> is a link to github.
+        For example, issue <GithubLink number={1} /> is a link to github.
       </Text>
     {/snippet}
   </ComponentSizes>
diff --git a/packages/ui/src/lib/components/GithubLink/GithubLink.svelte b/packages/ui/src/lib/components/GithubLink/GithubLink.svelte
index 2fbd7b3c..54e6706c 100644
--- a/packages/ui/src/lib/components/GithubLink/GithubLink.svelte
+++ b/packages/ui/src/lib/components/GithubLink/GithubLink.svelte
@@ -1,40 +1,10 @@
 <script lang="ts">
-  import Icon from '$lib/components/Icon/Icon.svelte';
   import Link from '$lib/components/Link/Link.svelte';
   import type { GithubLinkProps } from '$lib/types.js';
   import { asGithubLink } from '$lib/utilities/common.js';
-  import { siGithub } from 'simple-icons';
 
-  const { org, repo, number, type, size = 'medium', icon = true, ...rest }: GithubLinkProps = $props();
+  const { org, repo, number, type, ...rest }: GithubLinkProps = $props();
   const { href, text } = $derived(asGithubLink({ org, repo, number, type }));
-
-  const resolvedSize = $derived.by(() => {
-    switch (size) {
-      case 'tiny': {
-        return '7px';
-      }
-      case 'small': {
-        return '8px';
-      }
-      case 'medium': {
-        return '10px';
-      }
-      case 'large': {
-        return '12px';
-      }
-      case 'giant': {
-        return '14px';
-      }
-      default: {
-        return size;
-      }
-    }
-  });
 </script>
 
-<Link {...rest} {href} class="inline-flex items-center">
-  {#if icon}
-    <Icon icon={siGithub} size={resolvedSize} class="me-1" />
-  {/if}
-  {text}
-</Link>
+<Link {...rest} {href} class="inline-flex items-center">{text}</Link>
diff --git a/packages/ui/src/lib/types.ts b/packages/ui/src/lib/types.ts
index db6d9342..11f989db 100644
--- a/packages/ui/src/lib/types.ts
+++ b/packages/ui/src/lib/types.ts
@@ -492,13 +492,7 @@ export type LinkProps = {
 
 export type GithubLinkType = 'issue' | 'pr' | 'discussion';
 
-export type GithubLinkOptions = { org?: string; repo?: string; number?: number; type?: GithubLinkType };
-
-export type GithubLinkProps = {
-  icon?: boolean;
-  size?: Size;
-} & GithubLinkOptions &
-  LinkCommon;
+export type GithubLinkProps = { org?: string; repo?: string; number?: number; type?: GithubLinkType } & LinkCommon;
 
 export type MarkdownAlertVariant = 'note' | 'tip' | 'important' | 'warning' | 'caution' | 'info' | 'success' | 'danger';